Ticket #622: part0001.2.html

File part0001.2.html, 6.5 KB (added by Brian Smith, 6 months ago)

Added by email2trac

Line 
1
2<br><font size=2 face="sans-serif">re: MPI_Cart_map/MPI_Cart_create - I
3missed the connection there in the standard, though I assumed they were
4connected. I can submit an errata suggesting a clarification in MPI_Cart_map.</font>
5<br>
6<br><font size=2 face="sans-serif">And, I agree - I didn't see anything
7in 2.0 that said these tests were incorrect - they just seemed to be in
8semi-ambiguous areas and the Intel suite chose to interpret them as errors.
9We wouldn't have seen these if the tests hadn't start &quot;failing&quot;
10in MPICH2 1.1. </font>
11<br>
12<br><font size=2 face="sans-serif">Here's the relevant chunk of code for
13the MPI_Graph_create() &quot;error&quot;. This is MPI_Graph_create_err5
14in the test suite.</font>
15<br>
16<br><font size=2 face="sans-serif">#define &nbsp;DIMENSIONS &nbsp; &nbsp;
17&nbsp;2</font>
18<br><font size=2 face="sans-serif">#define &nbsp;TEST_DESC &nbsp; &nbsp;
19&nbsp; &quot;MPI_Graph_create with Null Edge&quot;</font>
20<br><font size=2 face="sans-serif">&nbsp; int</font>
21<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; index[4], &nbsp;
22&nbsp; &nbsp; &nbsp; /* graph cumulative connection count array &nbsp;
23&nbsp; &nbsp; &nbsp; &nbsp; */</font>
24<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; edges[6]; &nbsp;
25&nbsp; &nbsp; &nbsp; /* graph node neighbors list array &nbsp; &nbsp; &nbsp;
26&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; */</font>
27<br>
28<br><font size=2 face="sans-serif">&nbsp; num_dims = DIMENSIONS;</font>
29<br><font size=2 face="sans-serif">&nbsp; &nbsp;nnodes = 4;</font>
30<br>
31<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[1] = 3;</font>
32<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[2] = 0;</font>
33<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[3] = 3;</font>
34<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[4] = 0;</font>
35<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[5] = 2;</font>
36<br>
37<br><font size=2 face="sans-serif">&nbsp; &nbsp;index[0] = 2;</font>
38<br><font size=2 face="sans-serif">&nbsp; &nbsp;index[1] = 3;</font>
39<br><font size=2 face="sans-serif">&nbsp; &nbsp;index[2] = 4;</font>
40<br><font size=2 face="sans-serif">&nbsp; &nbsp;index[3] = 6;</font>
41<br>
42<br><font size=2 face="sans-serif">&nbsp; &nbsp;/*-----------------------------
43&nbsp;MPI_Graph_create &nbsp;------------------------*/</font>
44<br>
45<br><font size=2 face="sans-serif">&nbsp; &nbsp;edges[0] = 0;</font>
46<br>
47<br><font size=2 face="sans-serif">&nbsp; &nbsp;reorder = TRUE;</font>
48<br>
49<br><font size=2 face="sans-serif">&nbsp; &nbsp;ierr = MPI_Graph_create(MPI_COMM_WORLD,</font>
50<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
51nnodes,</font>
52<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
53index,</font>
54<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
55edges,</font>
56<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
57reorder,</font>
58<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
59&amp;comm_graph);</font>
60<br><font size=2 face="sans-serif">&nbsp; if (ierr == MPI_SUCCESS) {</font>
61<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; fail++;</font>
62<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; sprintf(info_buf,
63&quot;%s &nbsp;did not FAIL&quot;, TEST_DESC);</font>
64<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; MPITEST_message(MPITEST_NONFATAL,
65info_buf);</font>
66<br><font size=2 face="sans-serif">&nbsp; &nbsp;}</font>
67<br><font size=2 face="sans-serif">&nbsp;</font>
68<br>
69<br>
70<br><font size=2 face="sans-serif">Thanks.</font>
71<br>
72<br><font size=2 face="sans-serif"><br>
73Brian Smith<br>
74BlueGene MPI Development<br>
75IBM Rochester<br>
76Phone: 507 253 4717<br>
77smithbr@us.ibm.com<br>
78</font>
79<br>
80<br>
81<br>
82<table width=100%>
83<tr valign=top>
84<td width=40%><font size=1 face="sans-serif"><b>&quot;mpich2&quot; &lt;mpich2-maint@mcs.anl.gov&gt;</b>
85</font>
86<br><font size=1 face="sans-serif">Sent by: owner-mpich2-bugs@mcs.anl.gov</font>
87<p><font size=1 face="sans-serif">05/29/2009 08:19 AM</font>
88<table border>
89<tr valign=top>
90<td bgcolor=white>
91<div align=center><font size=1 face="sans-serif">Please respond to<br>
92mpich2-maint@mcs.anl.gov</font></div></table>
93<br>
94<td width=59%>
95<table width=100%>
96<tr valign=top>
97<td>
98<div align=right><font size=1 face="sans-serif">To</font></div>
99<td><font size=1 face="sans-serif">undisclosed-recipients: ;</font>
100<tr valign=top>
101<td>
102<div align=right><font size=1 face="sans-serif">cc</font></div>
103<td>
104<tr valign=top>
105<td>
106<div align=right><font size=1 face="sans-serif">Subject</font></div>
107<td><font size=1 face="sans-serif">Re: [mpich2-maint] #622: MPI_Graph_create
108with null edges, MPI_Cart_map with num_dims = 0</font></table>
109<br>
110<table>
111<tr valign=top>
112<td>
113<td></table>
114<br></table>
115<br>
116<br>
117<br><tt><font size=2>----------------------------------------------+-----------------------------<br>
118 Reporter: &nbsp;Brian Smith &lt;smithbr@us.ibm.com&gt; &nbsp;| &nbsp;
119&nbsp; &nbsp; &nbsp;Owner: &nbsp; &nbsp; <br>
120 &nbsp; &nbsp; Type: &nbsp;bug &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
121&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; | &nbsp;
122&nbsp; &nbsp; Status: &nbsp;new<br>
123 Priority: &nbsp;major &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
124&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp;Milestone:
125&nbsp; &nbsp; <br>
126Component: &nbsp;mpich2 &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
127&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;| &nbsp; Resolution: &nbsp;
128&nbsp; <br>
129 Keywords: &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
130&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;| &nbsp;<br>
131----------------------------------------------+-----------------------------<br>
132<br>
133<br>
134Comment (by gropp):<br>
135<br>
136 Brian,<br>
137<br>
138 These are good catches. &nbsp;On MPI_Cart_map, the MPI 2.1 behavior is
139implicit<br>
140 since page 255, lines 26ff state that MPI_Cart_create may be implemented<br>
141 with MPI_Cart_map. &nbsp;However, this should be made more explicit, so
142this<br>
143 deserves an errata item to the MPI 2.1 standard.<br>
144<br>
145 What are the index values for the Graph_create? &nbsp;I need to see those
146to<br>
147 understand the graph. &nbsp;(However, edges from a process to itself are<br>
148 permitted (p 247, lines 22-23)).<br>
149<br>
150 Note that there isn't anything in the standard that says that these were<br>
151 invalid; this was just the Intel test interpretation. &nbsp;The MPI 2.1<br>
152 behavior was defined to resolve the ambiguity (is it or isn't it valid).<br>
153<br>
154-- <br>
155Ticket URL: &lt;https://trac.mcs.anl.gov/projects/mpich2/ticket/622#comment:2&gt;<br>
156</font></tt>
157<br>