Changeset 4913

Timestamp:

07/07/09 23:34:39 (5 months ago)

Author:

balaji

Message:

Nemesis' implementation of memcpy seems to be broken for small
unaligned copies. This shows up in the TCP netmod when copying address
structures. The earlier version of the code used memcpy directly, so
this error didn't show up. In r4707, we moved it to use nemesis'
implementation of memcpy instead.

This patch falls back to using the default MPIUI_Memcpy instead of
nemesis' MPIU_Memcpy. This is a hack-fix for ticket #690. The right
fix is to correct the error in nemesis' MPIU_Memcpy.

Files:

• mpich2/trunk/src/mpid/ch3/channels/nemesis/nemesis/netmod/tcp/tcp_getip.c (modified) (2 diffs)

mpich2/trunk/src/mpid/ch3/channels/nemesis/nemesis/netmod/tcp/tcp_getip.c

@@ -179 +179 @@
                     myifaddr.type = AF_INET;
                     myifaddr.len  = 4;
-                    MPIU_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
+                    MPIUI_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
                 }
             }
@@ -186 +186 @@
                 myifaddr.type = AF_INET;
                 myifaddr.len  = 4;
-                MPIU_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
+                MPIUI_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
             }
         }