Changeset 4959

Timestamp:

07/13/09 17:30:11 (4 months ago)

Author:

buntinas

Message:

adding 'memory' to clobber list in asm memcpy implementations

Location:

mpich2/trunk/src/mpid/ch3/channels/nemesis/nemesis

Files:

• include/mpid_nem_memdefs.h (modified) (5 diffs)
• netmod/tcp/tcp_getip.c (modified) (2 diffs)

mpich2/trunk/src/mpid/ch3/channels/nemesis/nemesis/include/mpid_nem_memdefs.h

@@ -17 +17 @@
         __asm__ __volatile__ ("cld ; rep ; movsl ; movl %3,%0 ; rep ; movsb"            \
                               : "+c" (_nl), "+S" (_p), "+D" (_q)                        \
-                              : "r" ((n) & 3) /* : "memory" is this needed?*/);         \
+                              : "r" ((n) & 3) : "memory" );                             \
     } while (0)
 
@@ -117 +117 @@
                       : "=D" (dummy_dst), "=S" (dummy_src)
                       : "0" (dst), "1" (src), "g" (n >> 3)
-                      : "eax", "edx", "ecx"/* , "memory" is this needed? */);
+                      : "eax", "edx", "ecx", "memory" );
 
         src = (char *)src + n;
@@ -183 +183 @@
                       : "=D" (dummy_dst), "=S" (dummy_src) 
                       : "0" (dst), "1" (src), "g" (n >> 3)
-                      : "eax", "edx", "ecx" /* , "memory" is this needed? */);
+                      : "eax", "edx", "ecx", "memory" );
         src = (char *)src + n;
         dst = (char *)dst + n;
@@ -211 +211 @@
         __asm__ __volatile__ ("cld ; rep ; movsq ; movl %3,%%ecx ; rep ; movsb"                  \
                               : "+c" (_nq), "+S" (_p), "+D" (_q)                                 \
-                              : "r" ((uint32_t)((n) & 7)) /* : "memory" is this needed? */);     \
+                              : "r" ((uint32_t)((n) & 7)) : "memory" );                          \
     } while (0)
 
@@ -238 +238 @@
                       "mfence  \n"
                       : "+a" (n32), "+S" (src), "+D" (dst)
-                      : : "r8", "r9" /*, "memory" is this needed? */);
+                      : : "r8", "r9", "memory" );
     }
     

mpich2/trunk/src/mpid/ch3/channels/nemesis/nemesis/netmod/tcp/tcp_getip.c

@@ -179 +179 @@
                     myifaddr.type = AF_INET;
                     myifaddr.len  = 4;
-                    MPIUI_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
+                    MPIU_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
                 }
             }
@@ -186 +186 @@
                 myifaddr.type = AF_INET;
                 myifaddr.len  = 4;
-                MPIUI_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
+                MPIU_Memcpy( myifaddr.ifaddr, &addr.s_addr, 4 );
             }
         }