Ticket #689 (closed bug: fixed)

Opened 5 months ago

Last modified 4 months ago

Duplicate flags

Reported by: balaji Owned by: balaji
Priority: minor Milestone: future
Component: mpich2 Keywords:
Cc:

Description

In MPICH2's top-level configure.in, when arguments such as --enable-strict or --enable-g are passed, the corresponding flags are stored in MPICH2_EXTRA_CFLAGS and not in CFLAGS. When autoconf and confdb macros try out various compiler tests, they are not aware of these previous flags because of which they make incorrect decisions for some things. Finally, when the MPICH2 library is being compiled, when the MPICH2_EXTRA_CFLAGS appear in the compiler flags, the behavior of the compiler does not match what was detected by configure, resulting in errors. This was one of the reasons why --enable-strict didn't work correctly for a long time (signal/sigaction was another reason as well).

This ticket is a reminder that we need to go and clean up the configure script of this issue.

Attachments

Change History

Changed 4 months ago by balaji

  • status changed from new to closed
  • resolution set to fixed

This has been fixed in r4998. We are still running into problems with duplicate flags, but that's a different issue. Resolving this ticket.

Changed 4 months ago by chan

One of the reasons for the existence of MPICH2_EXTRA_*FLAGS is to check duplicated flags in flags added by MPICH2. Looking at r4998, all the works related to EXTRA_*FLAGS are removed, I believe configure should keep track of what flags are added by MPICH2. Not sure r4998 is a correct fix.

Changed 4 months ago by balaji

Duplicate flags can be avoided with CFLAGS too. Don't need another variable to keep track of it. MPICH2_EXTRA_*FLAGS is causing a bunch of other problems which we now avoid.

Changed 4 months ago by chan

Not sure what fix you did to avoid duplicated CFLAGS. We had long discussion that configure test should not touch/modify user supplied CFLAGS and that was the reason for the existence of EXTRA_*FLAGS. I will let you handle this issue.

Changed 4 months ago by balaji

  • priority changed from major to minor
  • status changed from closed to reopened
  • summary changed from MPICH2_EXTRA_CFLAGS vs. CFLAGS to Duplicate flags
  • resolution fixed deleted
  • milestone changed from mpich2-1.2 to future

As my comment above states, there is still a problem with duplicate flags. However, these can be checked while adding flags to CFLAGS. Checking this while adding flags to CFLAGS is no different from checking while adding flags to EXTRA_CFLAGS. I've added a macro called PAC_APPEND_FLAGS to check existing flags before appending them, which should be used everywhere.

I just checked and there seems to be no ticket that handles the duplicate flags. So, I'm converting this ticket to handle that for now. I'll take care of this soon-ish, though I don't think it's critical; it just looks ugly.

Changed 4 months ago by balaji

  • status changed from reopened to closed
  • resolution set to fixed

This was fixed by Dave for the 1.1.1p1 release. Resolving.

WARNING! You need to either login using OpenID here or enter your email address here before you can create or edit tickets. Otherwise the ticket will get treated as spam. More information on creating tickets can be found here.

Don't forget to add your email address to the cc list to make sure that you get updated of the ticket status.

Add/Change #689 (Duplicate flags)

Author



Change Properties
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.