Custom Query (894 matches)

In 1.4.0pre1, two issues actually.

1. Decision files never got read from disk with Pseudo FAM. This made decision lists always empty, obviously.

I'm unable to test the fix on Linux - will the files be read twice when using INotify?

2. A typo, which led to exceptions and empty decision lists.

--- a/src/lib/Bcfg2/Server/Plugins/Decisions.py
+++ b/src/lib/Bcfg2/Server/Plugins/Decisions.py
@@ -27,8 +27,8 @@
     def __init__(self, core):
         Bcfg2.Server.Plugin.Plugin.__init__(self, core)
         Bcfg2.Server.Plugin.Decision.__init__(self)
-        self.whitelist = DecisionFile(os.path.join(self.data, "whitelist.xml"))
-        self.blacklist = DecisionFile(os.path.join(self.data, "blacklist.xml"))
+        self.whitelist = DecisionFile(os.path.join(self.data, "whitelist.xml"), should_monitor=True)
+        self.blacklist = DecisionFile(os.path.join(self.data, "blacklist.xml"), should_monitor=True)

     def GetDecisions(self, metadata, mode):
-        return getattr(self, mode).get_decision(metadata)
+        return getattr(self, mode).get_decisions(metadata)

/mkd

I am running bcfg2 0.9.6pre1.

When a client specifies a profile on the command line and has an entry in clients.xml, there is a traceback:

Jun 20 15:22:14 ibm13 bcfg2-server[6946]: Asserting client shoryuken.ma.utexas.edu profile to hardy32
Jun 20 15:22:14 ibm13 bcfg2-server[6946]: Changing shoryuken.ma.utexas.edu group from hardy32 to hardy32
Jun 20 15:22:14 ibm13 bcfg2-server[6946]: Unexpected handler failure Traceback (most recent call last):   File "/usr/lib/python2.5/site-packages/Bcfg2/Component.py", line 220, in _cobalt_marshalled_dispatch     response = self._dispatch(method, (address, ) + params)   File "/usr/lib/python2.5/SimpleXMLRPCServer.py", line 415, in _dispatch     return func(*params)   File "/usr/sbin/bcfg2-server", line 149, in Bcfg2AssertProfile     self.Core.metadata.set_profile(client, profile, address)   File "/usr/lib/python2.5/site-packages/Bcfg2/Server/Plugins/Metadata.py", line 227, in set_profile     cli[0].set('profile', profile) IndexError: list index out of range

When the profile on the command line and the profile in clients.xml match, everything should work. I can understand failing if the profiles don't match. It would be reasonable to ignore either the command line specified profile or the server side profile, though.

This causes problems for reinstallations. I want to be able to install new machines without modifying clients.xml immediately so I put the profile on the command line in the kickstart post install. for a reinstallation, the client is already in clients.xml and so bcfg2 fails.

Wondering if we can add an additional parameter in <service> tag to specify sequence number instead of letting update-rc.d uses its default which I think is S20/K80.