Custom Query (894 matches)

This bug exists in Bcfg2 1.1.1.

Packages that are recording "Bad Package" with the reason being version differences are actually not a result of different version. They are actually an issue with specific files from the package having been modified. Take the following for example, "aaa_base" from a SuSE 10 client.

The running "bcfg2 -q -v -d" provides this snippet of output:

Verifying package instances for aaa_base
        0:10-12.58.1.x86_64
        verify_flags = ['', 'nomd5']
 {'files': [['RPMVERIFY_MTIME', 'c', '/etc/inittab'], 
 ['RPMVERIFY_FILESIZE', 'RPMVERIFY_MTIME', 'c', '/etc/mailcap'],
 ['RPMVERIFY_FILESIZE', 'RPMVERIFY_MTIME', 'c', '/etc/mime.types']],
 'nevra': ('aaa_base', None, '10', '12.58.1', 'x86_64')}
        Modlist/Ignore match: /etc/inittab
*** Instance 0:10-12.58.1.x86_64 failed RPM verification ***
        Package aaa_base failed verification.

It's clear that the error here is a result of the 3 files from the aaa_base RPM having been modified. However, the error gets recorded in the database as a version discrepancy, and not as files having been modified.

Reporting deviation from expected state must be done accurately in order to correct configurations.

We have a ConfigFile? defined that contains a unicode character that bcfg2-server is unable to decode. This results in a traceback on the server side, and a failure to create the file on the client side. I also tried this on our test server running 1.1.1, and the problem persists there, with the addition of a client-side traceback.

Server-side traceback

Feb 28 20:40:31 mgt14 bcfg2-server[4306]: Unexpected failure in BindStructure:
 Path /var/lib/ubcache/project-contacts
 Traceback (most recent call last):
   File "/usr/lib64/python2.4/site-packages/Bcfg2/Server/Core.py", line 202, in BindStructure
     self.Bind(entry, metadata)   File "/usr/lib64/python2.4/site-packages/Bcfg2/Server/Core.py", line 235, in Bind
     return glist[0].Entries[entry.tag][entry.get('name')](entry, metadata)
   File "/usr/lib64/python2.4/site-packages/Bcfg2/Server/Plugins/Cfg.py", line 99, in bind_entry
     entry.text = unicode(data, self.encoding) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 20946: ordinal not in range(128)

Client-side traceback (in 1.1.1):

Installing ConfigFile /var/lib/ubcache/project-contacts
Unexpected failure of install method for entry type Path
Traceback (most recent call last):
  File "/usr/lib64/python2.4/site-packages/Bcfg2/Client/Tools/__init__.py", line 150, in Install
    states[entry] = func(entry)
  File "/usr/lib64/python2.4/site-packages/Bcfg2/Client/Tools/POSIX.py", line 735, in InstallPath
    return ret(entry)
  File "/usr/lib64/python2.4/site-packages/Bcfg2/Client/Tools/POSIX.py", line 715, in Installfile
    return ret(entry)
  File "/usr/lib64/python2.4/site-packages/Bcfg2/Client/Tools/POSIX.py", line 674, in InstallConfigFile
    newfile.write(filedata)
TypeError: argument 1 must be string or read-only character buffer, not None

It would be great if the bcfg2-client could print the differences of UTF-8 encoded files (now it only shows the diff of ascii files).