Interactive client repeatedly asks whether to modify 'important' files

[https://profiles.google.com/holger.weiss]

"bcfg2 -I" gets confused when 'important' files are modified: the diff/prompt pairs are shown repeatedly (all in all: four times), and the prompt must be confirmed twice.

[solj]

I am unable to reproduce this behavior in the latest code:

# bcfg2 -vqIb base-gentoo                                                                                         
Running probe current-kernel
Probe current-kernel has result:
2.6.36-gentoo-r8
Running probe groups
Probe groups has result:
group:gentoo
group:linux
group:amd64
Loaded tool drivers:
 Action    POSIX     Portage   RcUpdate  VCS


Phase: initial
Correct entries:        4
Incorrect entries:      7
Total managed entries:  11
Unmanaged entries:      239

--- 

+++ 

@@ -1,1 +1,2 @@

+test
 
Install Path /test.txt: (y/N): 

Phase: final
Correct entries:        4
Incorrect entries:      1
 Path:/test.txt                  
Total managed entries:  5
Unmanaged entries:      239

# bcfg2 -vqIb base-gentoo
Running probe current-kernel
Probe current-kernel has result:
2.6.36-gentoo-r8
Running probe groups
Probe groups has result:
group:gentoo
group:linux
group:amd64
Loaded tool drivers:
 Action    POSIX     Portage   RcUpdate  VCS


Phase: initial
Correct entries:        4
Incorrect entries:      7
Total managed entries:  11
Unmanaged entries:      239

--- 

+++ 

@@ -1,1 +1,2 @@

+test
 
Install Path /test.txt: (y/N): y
Installing file /test.txt
The Following Bundles have been modified:
 base-gentoo 


Phase: final
Correct entries:        5
Incorrect entries:      0
Total managed entries:  6
Unmanaged entries:      239

[https://profiles.google.com/holger.weiss]

Replying to solj:

I am unable to reproduce this behavior in the latest code:

# bcfg2 -vqIb base-gentoo

[...]

Can you reproduce it when you try this without the "-b" flag? When I specify "-b <bundle>", I can't reproduce the problem either.

[solj]

I think ​https://gist.github.com/1036917 should fix the problem for you.

[https://profiles.google.com/holger.weiss]

Replying to solj:

I think ​https://gist.github.com/1036917 should fix the problem for you.

This works fine if I confirm the prompt by answering "y"(es), but a "N"(o) reply must still be confirmed twice.

[solj]

Fixed in b3bad727bc0968cd8b7fb29573e74d551a13c74d.