Run testsuite directly from checkout

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

Bcfg2 source layout doesn't allow to run testsuite directly from checkout. Even if you set PYTHONPATH=src/lib this won't work, because lib/ directly contains modules that should be available from Bcfg2 package in order to be found by import statements in Python scripts.

$ PYTHONPATH=src/lib nosetests -d testsuite
EEE
======================================================================
ERROR: Failure: ImportError (No module named Bcfg2.Client.Frame)
...
ImportError: No module named Bcfg2.Server.Core

----------------------------------------------------------------------
Ran 3 tests in 0.295s

The solution is to move Bcfg2 source to a subfolder named Bcfg2.

[solj]

This can be accomplished using the instructions at ​http://docs.bcfg2.org/dev/development/setup.html#checking-out-a-copy-of-the-code.

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

I often work from a network disk using samba share that doesn't allow links to be created.

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

I also don't understand why you want this extra step to be present.

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

What advantages does it provide?

[solj]

Replying to https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU:

I often work from a network disk using samba share that doesn't allow links to be created.

You can probably just create a git hook in that case to copy the contents over to a Bcfg2 directory.

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

Replying to solj:

Replying to https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU:

I often work from a network disk using samba share that doesn't allow links to be created.

You can probably just create a git hook in that case to copy the contents over to a Bcfg2 directory.

I doubt it copies the contents each time the code is modified, which means I need to hack on copy of the code, which means the hook should detect changes in copy and be able to merge between copy and modifications in the checkout. I really doubt there is an existing Git hook to support that and ISTM that it is an overkill to create one.

Bcfg2 source code misses top level package structure that is required by Python and I can't understand the reasons to keep it this way and require extra 'compilation' steps when they can be safely avoided.

[solj]

I think we can change this relatively easily by moving src/lib/* to src/lib/Bcfg2. Since this involves moving a few things around and changing things in setup.py, I think we will wait until after 1.2.0 is released to do it.

[solj]

Added this capability in dab1d03d81c538966d03fb9318a4588a9e803b44.

[https://www.google.com/accounts/o8/id?id=AItOawkPb0RtPyicSdU7pLcv1UrX-yCh-YjkOwU]

Good to see this fixed.