Ticket #1052 (closed defect: fixed)
`bcfg -ven` vs. `bcfg -I` yield different output
Reported by: | https://www.google.com/accounts/o8/id?id=AItOawkjKgZsrk-wj8Ikb2eLLRqMctAjiqUuv2g | Owned by: | https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc |
---|---|---|---|
Priority: | minor | Milestone: | Bcfg2 1.2.1 Release (Bugfix) |
Component: | bcfg2-client | Version: | 1.0 |
Keywords: | Cc: | [email protected]… |
Description
When using the bcfg2-accounts plugin (https://github.com/weiss/bcfg2-accounts),\
and adding a new user to Properties/accounts.xml.
bcfg2 -n : gives no indication that an action is necessary.
bcfg2 -I : works as expected. Expected meaning you are prompted to modify the \ user.
An example can be found here: http://pastebin.com/A0Uf4Gz4. You may ignore the\
question about why usermod is being called at all.
Attachments
Change History
comment:2 Changed 12 years ago by solj
- Milestone changed from Bcfg2 1.3.0 Release to Bcfg2 1.2.1 Release (Bugfix)
comment:3 Changed 12 years ago by https://www.google.com/accounts/o8/id?id=AItOawmhfxIOg3eM29zqtzKItP4pG8fxKrMlb8w
- Cc [email protected]… added
comment:4 Changed 11 years ago by https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
- Owner changed from desai to https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
- Status changed from new to accepted
comment:5 Changed 11 years ago by https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
- Status changed from accepted to closed
- Resolution set to fixed
comment:6 Changed 11 years ago by https://www.google.com/accounts/o8/id?id=AItOawlP6DRBvIJ7NLpLWILbgzURvGbMtGEyd8U
- Status changed from closed to reopened
- Resolution fixed deleted
I can reproduce the problem with Bcfg2 1.2.3.
comment:7 Changed 11 years ago by https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
- Status changed from reopened to closed
- Resolution set to fixed
Sorry, I misunderstood the issue here; pre and both actions were not reliably showing up in -I, either, and that's what I fixed.
I've now fixed the issue with -n output as well:
https://github.com/Bcfg2/bcfg2/commit/a95c365f39d983986e1a69e8396101e87ff08abb https://github.com/Bcfg2/bcfg2/commit/a7c9889a88233f8ea3ff7f05fa4234d30cf9279c
Just to clarify: this issue is unrelated to the bcfg2-accounts stuff. It can easily be reproduced using the following entry as a test case:
<Action name='test' timing='pre' when='always' status='check' command='/bin/true'/>
This <Action> won't be mentioned by bcfg2 -vn, and it won't be added to the list of Bad Entries. If the timing attribute is set to post, the entry will be handled as expected.