Modify

Ticket #1143 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

Cfg in maint allows you to use non-dots to concatenate the basename and the Group name.

Reported by: https://www.google.com/accounts/o8/id?id=AItOawn0s7RDAZJqmy8qhaS8PFtgoke6VxxZKSI Owned by: desai
Priority: minor Milestone:
Component: bcfg2-server Version: 1.0
Keywords: Cc:

Description

I was looking at this line in the 'maint' branch, and I believe it doesn't properly escape the '.', so you could use any character.

I realized we were using '-' in a couple places, so this behavior is verified. While I don't really expect this to be fixed in maint, it is a kind of undocumented behavior that others might not realize they are relying on.

I looked at the 'master' branch and it uses better regex so it might not be a problem (although does this line have the properly escaped '.'? There's only one slash, instead of the two used in the Host part the line above. I'm not terribly familiar with Python regexes).

Attachments

Change History

comment:1 Changed 9 years ago by https://www.google.com/accounts/o8/id?id=AItOawn0s7RDAZJqmy8qhaS8PFtgoke6VxxZKSI

  • Priority changed from major to minor

comment:2 Changed 8 years ago by solj

  • Status changed from new to closed
  • Resolution set to fixed

This appears to be fixed in 1.3.4.

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.