Modify ↓
Ticket #373 (closed defect: fixed)
bcfg2-build-reports wrongly displays hosts as "bad"
Reported by: | [email protected]… | Owned by: | desai |
---|---|---|---|
Priority: | minor | Milestone: | Bcfg2 0.9.0 Release |
Component: | bcfg2-reports | Version: | |
Keywords: | Cc: |
Description
the cause: bcfg2-build-reports wants to remove "bad"-elements that do not have any children, but elementree seems to return an empty list in this case, not None.
--- bcfg2-build-reports.orig 2007-01-22 17:57:12.000000000 +0100 +++ bcfg2-build-reports 2007-01-22 17:57:22.000000000 +0100 @@ -41,7 +41,7 @@ SubElement(stats,"Good") [stats.remove(item) for item in stats.findall("Bad") + stats.findall("Modified") if \ - item.getchildren() == None] + item.getchildren() == []] [stats.remove(item) for item in stats.findall("Modified") if reportmodified == 'N'] #test for staleness -if stale add Stale tag
Attachments
Change History
Note: See
TracTickets for help on using
tickets.
Commited in [34ea17b19e5fefa2c9b2a6db3ec28c36e0025453] (SVN r2707). Thanks for the patch.