Modify ↓

Ticket #373 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

bcfg2-build-reports wrongly displays hosts as "bad"

Reported by: [email protected]… Owned by: desai
Priority: minor Milestone: Bcfg2 0.9.0 Release
Component: bcfg2-reports Version:
Keywords: Cc:

Description

the cause: bcfg2-build-reports wants to remove "bad"-elements that do not have any children, but elementree seems to return an empty list in this case, not None. 

--- bcfg2-build-reports.orig	2007-01-22 17:57:12.000000000 +0100
+++ bcfg2-build-reports	2007-01-22 17:57:22.000000000 +0100
@@ -41,7 +41,7 @@
             SubElement(stats,"Good")
 
         [stats.remove(item) for item in stats.findall("Bad") + stats.findall("Modified") if \
-         item.getchildren() == None]
+         item.getchildren() == []]
         [stats.remove(item) for item in stats.findall("Modified") if reportmodified == 'N']
                 
         #test for staleness -if stale add Stale tag

Attachments

Change History

comment:1 Changed 15 years ago by desai

  • Status changed from new to closed
  • Resolution set to fixed

Commited in [34ea17b19e5fefa2c9b2a6db3ec28c36e0025453] (SVN r2707). Thanks for the patch.

comment:2 Changed 15 years ago by desai

  • Milestone set to Bcfg2 0.9.0 Release

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.