Encaps need better string splitting regexps

[dclark]

There are 3 issues with the regular expression code used to parse "file=" Pkgmgr entries:

1. epkg.log is a special case and should just be ignored.
2. File names like openssh-4.6p1+2-encap-ix86-linux_debian_etch.tar.gz fail, I think due to the "+" character, which is actually a recommended encap convention to denote site-specific/packaging changes.
3. File names like bcfg2-python-apt-0.6.19-encap-ix86-linux_debian_etch.tar.gz fail, I think due to the multiple "-" characters before the version.

I think all of these need to be fixed in both Client (src/lib/Client/Tools/Encap.py) and Server (src/lib/Server/Plugins/Pkgmgr.py) side code.

[dclark]

Here is a (hopefully correctly) commented version of the current regexps for posterity:

pkgmgr = re.compile( r'''
         (?x)    # verbose - Split a stand-alone encap package name.
         ^       # Begin string
             (?P<name>    # Give the matched text the name "name"
             \w+)         # Match one or more words
         -       # Break on "-"
             (?P<version> # Give the matched text the name "version"
             [\w\d\.-]+)  # Match one or more words, digits, periods, or hyphens
         .       # Followed by any character
         encap   # And then the word "encap"
         .*      # Followed by anything
         $       # And then end of line
         ''')

encap = re.compile( r'''
        (?x)    # verbose - Split an encap package name at the end of a path.
        .*/     # We have any amount of stuff ending with a final "/"
            (?P<name>    # Give the matched text the name "name"
            [\w-]+)      # Match one or more words or hyphens
        \-      # Break on "-". I think the escape is unessisary (TEST)
            (?P<version> # Give the matched text the name "version"
            [\w\.-]+)    # Match one or more words, periods, or hyphens
        ''')

[dclark]

Fixed in r3482