Ticket #511 (closed defect: fixed)
SYSV client tool unnecessarily requires url attribute for package verification
| Reported by: | [email protected]… | Owned by: | desai |
|---|---|---|---|
| Priority: | minor | Milestone: | Bcfg2 0.9.5 Release |
| Component: | bcfg2-client | Version: | 0.9.x |
| Keywords: | Cc: |
Description
[23021187d09ee95a6502dd57bd606561f858e87b] (SVN r3425) introduced the addition of 'url' to __req__['Package'] for SYSV.py. While the url attribute is required for installing a SYSV package, it is certainly not necessary for verifying or removing one. Some (most?) SYSV packages have no meaningful URL, e.g. the ones that come on the Solaris install DVD. And the Blast client tool does not ever use the 'url' attribute, but it inherits the requirement since it is a subclass of SYSV.
From what I can tell from reading the source, the __req__ structure defines required attributes for all operations on an object (a package in this specific case), and __ireq__ is for attributes that are required for installing an object. So, SYSV should have __ireq__ defined with the 'url' attribute, and __req__ should have 'url' left out.
I'll attach a patch, which is hopefully clearer than my incoherent rambling. This isn't all too important, since it's easy enough to add a dummy url attribute to the package definitions, but it's just silly.
Committed in [cf543994b8be92232ca636992ae64321148741e3] (SVN r4155). Thanks for the patch.