Modify ↓
Ticket #620 (closed defect: fixed)
bcfg2-repo-validate handles bundle as info.xml file
Reported by: | Martin <[email protected]…> | Owned by: | desai |
---|---|---|---|
Priority: | trivial | Milestone: | Bcfg2 0.9.6 Release |
Component: | bcfg2-server | Version: | 0.9.x |
Keywords: | Cc: |
Description
If you have a Bundle named foobar-info.xml, bcfg2-repo-validate will handle this file as an info.xml file so the verification fails. This is because of these lines in bcfg2-repo-validate:
# Get a list of all info.xml files in the bcfg2 repository info_list = [] for root, dirs, files in os.walk('%s' % repo): for filename in files: if filename.endswith('info.xml'): info_list.append(os.path.join(root, filename))
Why do you check if the filename ends with 'info.xml'? If you check for identity everthing is fine so please replace
if filename.endswith('info.xml'):
with
if filename == 'info.xml':
But what ist if you have Bundle name 'info.xml'? In my oppinion you should not search the Bundle dir for info.xml files.
Attachments
Change History
Note: See
TracTickets for help on using
tickets.
Resolved in [45b4a330dcf8a862ab271a50cd7b052a77a2e0db] (SVN r4994)