Improper TLSError handling in Proxy.py

[kisielk]

A traceback from the bcfg2 client:

Traceback (most recent call last):
  File "/usr/sbin/bcfg2", line 453, in ?
    client.run()
  File "/usr/sbin/bcfg2", line 335, in run
    proxy.RecvStats(Bcfg2.Client.XML.tostring(feedback, encoding='UTF-8', xml_declaration=True))
  File "/usr/sbin/bcfg2", line 45, in __call__
    return self.method(*args)
  File "/usr/lib64/python2.4/site-packages/Bcfg2/Proxy.py", line 41, in __call__
    self.log.error("Unexpected TLS Error: %s. Retrying" % \
AttributeError: TLSAbruptCloseError instance has no attribute 'message'

The offending line in Proxy.py:

except Bcfg2.tlslite.errors.TLSError, err:
                self.log.error("Unexpected TLS Error: %s. Retrying" % \
                               (err.message))

I believe that replacing err.message with just err fixes the problem (although for my particular error the message is just "Unexpected TLS Error: . Retrying" and I don't know why that is happening, but that's a separate issue).

[desai]

Resolved in [6ac0ad8babaee28757bc6d9372bf1ecf6ee16bd4] (SVN r4990).