Modify ↓
Ticket #630 (closed defect: fixed)
Blast and SYSV client tools using suboptimal 'mktemp'
| Reported by: | [email protected]… | Owned by: | solj |
|---|---|---|---|
| Priority: | minor | Milestone: | Bcfg2 1.0.0 Release |
| Component: | bcfg2-client | Version: | 1.0 |
| Keywords: | Cc: |
Description
Both the Blast and SYSV client package tools use tempfile.mktemp(), which is insecure, and leaves the temporary file around after bcfg2 has finished running. This eventually leaves me with many Solaris boxes with /tmp full of tmpXXXXXX files.
The attached patch uses tempfile.NamedTemporaryFile?() instead, which solves both of these problems. This requires python 2.3, though; is that acceptable?
Attachments
Change History
Changed 14 years ago by [email protected]…
- Attachment mktemp-namedtemporaryfile.patch added
comment:1 Changed 14 years ago by solj
- Version set to 0.9.x
- Milestone set to Bcfg2 0.9.6.1 (Reporting System Bugfixes)
comment:2 Changed 14 years ago by solj
- Owner changed from desai to solj
- Status changed from new to assigned
comment:3 Changed 14 years ago by solj
- Status changed from assigned to closed
- Resolution set to fixed
Committed to the stable stream in [5052]. Also committed to trunk as part of the 1.0pre1 release in [8c2821c5134f5dfc7f78183793fcb8c1b4d92e00] (SVN r5049). Thanks for the patch.
Note: See
TracTickets for help on using
tickets.
Use tempfile.NamedTemporaryFile? instead of tempfile.mktemp