Modify

Ticket #630 (closed defect: fixed)

Opened 13 years ago

Last modified 13 years ago

Blast and SYSV client tools using suboptimal 'mktemp'

Reported by: [email protected] Owned by: solj
Priority: minor Milestone: Bcfg2 1.0.0 Release
Component: bcfg2-client Version: 1.0
Keywords: Cc:

Description

Both the Blast and SYSV client package tools use tempfile.mktemp(), which is insecure, and leaves the temporary file around after bcfg2 has finished running. This eventually leaves me with many Solaris boxes with /tmp full of tmpXXXXXX files.

The attached patch uses tempfile.NamedTemporaryFile?() instead, which solves both of these problems. This requires python 2.3, though; is that acceptable?

Attachments

mktemp-namedtemporaryfile.patch (1.4 KB) - added by [email protected] 13 years ago.
Use tempfile.NamedTemporaryFile? instead of tempfile.mktemp

Change History

Changed 13 years ago by [email protected]

Use tempfile.NamedTemporaryFile? instead of tempfile.mktemp

comment:1 Changed 13 years ago by solj

  • Version set to 0.9.x
  • Milestone set to Bcfg2 0.9.6.1 (Reporting System Bugfixes)

comment:2 Changed 13 years ago by solj

  • Owner changed from desai to solj
  • Status changed from new to assigned

comment:3 Changed 13 years ago by solj

  • Status changed from assigned to closed
  • Resolution set to fixed

Committed to the stable stream in [5052]. Also committed to trunk as part of the 1.0pre1 release in [8c2821c5134f5dfc7f78183793fcb8c1b4d92e00] (SVN r5049). Thanks for the patch.

comment:4 Changed 13 years ago by solj

  • Version changed from 0.9.x to 1.0
  • Milestone changed from Bcfg2 0.9.6.1 (Reporting System Bugfixes) to Bcfg2 1.0 Release

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.