Modify

Ticket #641 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

bcfg2 checks warns of missing gpg key even if nosignature is used

Reported by: anonymous Owned by: solj
Priority: major Milestone: Bcfg2 1.0.0 Release
Component: bcfg2-client Version: 1.0
Keywords: Cc:

Description

e.g. WARNING: Package bcfg2 0.9.6-1.el5.noarch requires GPG Public key with ID 119cc036 217521f6

Disabling signature check.

with:

<Package name='bcfg2' verify_flags="nosignature">

<Instance version='0.9.6' release='1.el5' arch='noarch' />

</Package>

bcfg2-server-0.9.6-1.el5 bcfg2-0.9.6-1.el5

Attachments

Change History

comment:1 Changed 14 years ago by solj

  • Milestone set to Bcfg2 0.9.6.1 (Reporting System Bugfixes)

comment:2 Changed 14 years ago by solj

  • Owner changed from desai to solj
  • Status changed from new to assigned

comment:3 Changed 14 years ago by solj

I believe this should do the trick, however, I don't have a machine to test it on. Can you see if this works for you?

diff --git a/src/lib/Client/Tools/RPMng.py b/src/lib/Client/Tools/RPMng.py
index fd440e4..7626ad1 100644
--- a/src/lib/Client/Tools/RPMng.py
+++ b/src/lib/Client/Tools/RPMng.py
@@ -268,7 +268,8 @@ class RPMng(Bcfg2.Client.Tools.PkgTool):
                                     if self.pkg_verify == 'true' and \
                                        inst.get('pkg_verify', 'true') == 'true':
                                         flags = inst.get('verify_flags', '').split(',') + self.verify_flags
-                                        if pkg.get('gpgkeyid', '')[-8:] not in self.gpg_keyids:
+                                        if pkg.get('gpgkeyid', '')[-8:] not in self.gpg_keyids and \
+                                           'nosignature' not in flags:
                                             flags += ['nosignature', 'nodigest']
                                             self.logger.info('WARNING: Package %s %s requires GPG Public key with ID %s'\
                                                          % (pkg.get('name'), self.str_evra(pkg), \

comment:4 Changed 14 years ago by solj

  • Status changed from assigned to closed
  • Resolution set to fixed

This should be resolved in [668ecd8345aa2943187df23c1130c1dceaa564b1] (SVN r5074).

comment:5 Changed 14 years ago by solj

  • Version changed from 0.9.x to 1.0
  • Milestone changed from Bcfg2 0.9.6.1 (Reporting System Bugfixes) to Bcfg2 1.0 Release

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.