Modify

Ticket #672 (closed enhancement: fixed)

Opened 13 years ago

Last modified 10 years ago

bcfg2-admin should not process any config files when help is requested

Reported by: Jon Nials <jnials@…> Owned by: solj
Priority: minor Milestone: Bcfg2 1.2.0 Release
Component: bcfg2-server Version: 1.0
Keywords: bcfg2-admin Packages Cc: sol.jerome@…

Description

bcfg2-admin should NOT process the Packages/config.xml if any help command is executed.

Recreate:

bcfg2-admin minestruct help

produces output and refreshes the cache. It should only do this if you actually execute a command.

Attachments

Change History

comment:1 Changed 12 years ago by solj

  • Milestone changed from Bcfg2 1.0 Release to Bcfg2 1.0.1 Release

comment:2 Changed 12 years ago by solj

  • Milestone changed from Bcfg2 1.0.1 Release to Bcfg2 1.1.0 Release

comment:3 Changed 11 years ago by solj

  • Milestone changed from Bcfg2 1.1.0 Release to Bcfg2 1.1.1 Release (Bugfix)

comment:4 Changed 11 years ago by solj

  • Milestone changed from Bcfg2 1.1.1 Release (Bugfix) to Bcfg2 1.1.2 Release (Bugfix)

comment:5 Changed 11 years ago by solj

  • Milestone changed from Bcfg2 1.1.2 Release (Bugfix) to Bcfg2 1.2.0 Release

comment:6 Changed 10 years ago by solj

  • Cc sol.jerome@… added
  • Owner changed from desai to solj
  • Status changed from new to accepted

I believe that this patch should fix the problem.

diff --git a/src/lib/Server/Admin/__init__.py b/src/lib/Server/Admin/__init__.py
index b34d710..41c485d 100644
--- a/src/lib/Server/Admin/__init__.py
+++ b/src/lib/Server/Admin/__init__.py
@@ -53,9 +53,7 @@ class Mode(object):
     cfp = property(getCFP)
 
     def __call__(self, args):
-        if len(args) > 0 and args[0] == 'help':
-            print(self.__longhelp__)
-            raise SystemExit(0)
+        pass
 
     def errExit(self, emsg):
         print(emsg)
diff --git a/src/sbin/bcfg2-admin b/src/sbin/bcfg2-admin
index 36be6ab..419d223 100755
--- a/src/sbin/bcfg2-admin
+++ b/src/sbin/bcfg2-admin
@@ -62,6 +62,9 @@ def main():
 
     if args[0] in get_modes():
         modname = args[0].capitalize()
+        if args[1] == 'help':
+            print(mode_import(modname).__longhelp__)
+            raise SystemExit(0)
         try:
             mode_cls = mode_import(modname)
         except ImportError:

comment:7 Changed 10 years ago by solj

  • Status changed from accepted to closed
  • Resolution set to fixed

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.