Plugins/Deps.py needs svn:keywords set

[mccallis]

The bcfg2-info looks like it uses the expanded svn $Id:$ keyword to produce the output in response to the generators command. Currently in 1.0 pre5, I see the following when I issue that command:

> generators
$Id: Rules.py 5004 2009-01-05 03:24:50Z desai $
$Id: Cfg.py 5119 2009-03-16 01:31:36Z desai $
$Id: Pkgmgr.py 5245 2009-05-20 01:14:42Z desai $
$Id: SSHbase.py 5387 2009-07-27 00:08:10Z desai $
$Id:$
$Id: TCheetah.py 5339 2009-07-16 03:42:25Z desai $

From cross-referencing my list of configured Plugins and the output, it seems the source:trunk/bcfg2/src/lib/Server/Plugins/Deps.py file is not enabled to expand svn keywords. Clicking around in the repository shows other files (e.g., source:trunk/bcfg2/src/lib/Server/Plugins/NagiosGen.py) also contain keyword expansions but are not configured for such in svn. It's probably best just to kick off the following:

svn propset svn:keywords "Date Author Id Revision" src/lib/Server/Plugins/*.py

This will make everything match the keywords expanded for source:trunk/bcfg2/src/lib/Server/Plugins/Cfg.py.

A question of style is would it make sense to rename the command itself to "plugins", since "generators" is no longer the name used in the config file?

Mike

[solj]

Replying to mccallis:

The bcfg2-info looks like it uses the expanded svn $Id:$ keyword to produce the output in response to the generators command. Currently in 1.0 pre5, I see the following when I issue that command:

> generators
$Id: Rules.py 5004 2009-01-05 03:24:50Z desai $
$Id: Cfg.py 5119 2009-03-16 01:31:36Z desai $
$Id: Pkgmgr.py 5245 2009-05-20 01:14:42Z desai $
$Id: SSHbase.py 5387 2009-07-27 00:08:10Z desai $
$Id:$
$Id: TCheetah.py 5339 2009-07-16 03:42:25Z desai $

From cross-referencing my list of configured Plugins and the output, it seems the source:trunk/bcfg2/src/lib/Server/Plugins/Deps.py file is not enabled to expand svn keywords. Clicking around in the repository shows other files (e.g., source:trunk/bcfg2/src/lib/Server/Plugins/NagiosGen.py) also contain keyword expansions but are not configured for such in svn. It's probably best just to kick off the following:

svn propset svn:keywords "Date Author Id Revision" src/lib/Server/Plugins/*.py

This will make everything match the keywords expanded for source:trunk/bcfg2/src/lib/Server/Plugins/Cfg.py.

Added the keywords to all the Server plugins in [5a374b8be640be6baf1b435499596999bedec1f8] (SVN r5416). Thanks for the bug report.

A question of style is would it make sense to rename the command itself to "plugins", since "generators" is no longer the name used in the config file?

Since there is still a distinction between generators and other types of plugins, I'm not sure that we want to rename the function.

Mike

[Richardheef]

Coastal command's hard-fought lamb would make land suit habits a vast image. ​https://my.swu.edu/ICS/icsfs/tabfen10.html?target=e857e422-f2bc-412b-af55-28cd1533af09 High wide passenger para offer systems to characters in the buy phentermine 37.5 mg of companies.