Python block in Genshi bundle causes traceback

[Bruce Bush <[email protected]…>]

Using bcfg2 v 1.0.1 on CentOS 5.4 - Genshi bundle containing a python block causes traceback:

This example causes a traceback: <Bundle name='awstats' xmlns:py="http://genshi.edgewall.org/">

<?python

vhosts = $metadata.Probesvhosts?.split(":")

?> <ConfigFile? py:for="vhost in vhosts" name='/etc/bruce/package-${vhost}' altsrc='/etc/testfile' />

</Bundle>

This example works: <Bundle name='awstats' xmlns:py="http://genshi.edgewall.org/"> <py:for each="vhost in metadata.Probes['vhosts'].split(':')" >

<ConfigFile? name='/etc/bruce/package-${vhost}' altsrc='/etc/testfile' />\

</py:for> </Bundle>

[solj]

This works for me. Here is a simple example:

<!--
vim: ft=xml
-->
<Bundle name='test' xmlns:py="http://genshi.edgewall.org/" lang='en'>
<?python
test = metadata.Probes.keys()
?>
        <Path name='/etc/${test}' altsrc='/foo'/>
</Bundle>

[Manush Dodunekov <…>]

I can reproduce this on CentOS 5.4 x86_64. Here is the traceback:

error in BindStructure
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/Bcfg2/Server/Core.py", line 258, in BuildConfiguration
    self.BindStructure(astruct, meta)
  File "/usr/lib/python2.4/site-packages/Bcfg2/Server/Core.py", line 175, in BindStructure
    if entry.tag.startswith("Bound"):
AttributeError: 'builtin_function_or_method' object has no attribute 'startswith'

The problem appears whenever a bundle in Bundler contains a PI or a comment.

[solj]

Replying to Manush Dodunekov <[email protected]…>:

I can reproduce this on CentOS 5.4 x86_64. Here is the traceback:

error in BindStructure
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/Bcfg2/Server/Core.py", line 258, in BuildConfiguration
    self.BindStructure(astruct, meta)
  File "/usr/lib/python2.4/site-packages/Bcfg2/Server/Core.py", line 175, in BindStructure
    if entry.tag.startswith("Bound"):
AttributeError: 'builtin_function_or_method' object has no attribute 'startswith'

The problem appears whenever a bundle in Bundler contains a PI or a comment.

I'm unable to reproduce this. Can you paste your bundle please?

[Manush Dodunekov <…>]

Replying to solj:

Here is a config that triggers the problem:

Bundler/test-bundle.xml:

<Bundle name="test-bundle" xmlns:py="http://genshi.edgewall.org/">
  <?python
    s = "whatever"
  ?>
  <BoundConfigFile name="/tmp/test.txt" owner="root" group="root" perms="0644">${s}</BoundConfigFile>
</Bundle>

Relevant part of GroupPatterns/config.xml:

<GroupPatterns>
  <GroupPattern>
    <NamePattern>testclient\.domain</NamePattern>
    <Group>test</Group>
  </GroupPattern>
</GroupPatterns>

Relevant part of Metadata/groups.xml:

<Groups version="3.0">
   <Group name="test">
     <Bundle name="test-bundle"/>
   </Group>
</Groups>

[solj]

Replying to Manush Dodunekov <[email protected]…>:

This, also, works for me. I'm guessing this must be a CentOS problem. I'll look into it when I get a chance.

[Manush Dodunekov <…>]

After reading through Plugins/Bundler? one more time, I renamed test-bundle.xml to test-bundle.genshi and things started working as expected.

A suggestion would be to treat any bundle with xmlns:py="http://genshi.edgewall.org/" as a genshi bundle instead of relying on the filename extension.

[solj]

We might be able to do something like this. In the meantime, moving it to the next feature release.

[solj]

The ability to use genshi templates in files having a .xml extension has been added in 1dcb73e1a06d3a558b498ec5d5a47ff562254b7d.