bcfg2-server should not remove comments from clients.xml

[m4z <[email protected]…>]

Due to an error on my part, a client was recognized as new and added to the config:

Asserting client foo.example.org profile to basic
Creating new client: foo.example.org, profile basic

That's fine, however when i opened my (heavily commented) clients.xml afterwards, all the comments where removed. ):

Is this a feature? If so, where is the red, bold, blinking warning sign?

[m4z <…>]

What's even worse is that bcfg2-server does not check if the file was modified since it last read it, and overwrites the clients.xml with the last version it had in memory.

So if I...

1. run a server without a file monitor(0)
2. change the groups.xml and save it
3. an unknown/new client connects before bcfg2-server is restarted

...then all changes from step 2 will be overwritten.

(0): On openSUSE, I'm somewhat forced to do that right now, because gamin does not exist in the "main" repositories, and fam does not (yet?) work for me.

[laszlo]

Comments stripping fixed in 00bf7d31dd04f2f33a71c6fbd88a5349f5bcd482. Working on the overwrite issue.

[laszlo]

clients.xml is now reloaded if Pseudo is used. 2684e59560d0bd799b78d9a432ff15f713298333