Modify

Ticket #944 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

dependency resolver rewrite (changeset 6040) removes whitelist handling

Reported by: Richard Connon <[email protected]…> Owned by: desai
Priority: major Milestone: Bcfg2 1.1.0 Release
Component: bcfg2-server Version: 1.0
Keywords: dependency whitelist Cc:

Description

The package source whitelist is no longer handled by the dependency resolver so bcfg2 tries to install unwhitelisted packages.

Attachments

blacklist-whitelist.patch (3.4 KB) - added by Richard Connon <[email protected]…> 12 years ago.
blacklist-whitelist.2.patch (3.6 KB) - added by Richard Connon <[email protected]…> 12 years ago.
patch fixing the issue (with correct indentation)

Change History

comment:1 Changed 12 years ago by solj

  • Component changed from bcfg2-client to bcfg2-server
  • Summary changed from dependency resolver rewrite (changeset 6400) removes whitelist handling to dependency resolver rewrite (changeset 6040) removes whitelist handling

Changed 12 years ago by Richard Connon <[email protected]…>

comment:2 Changed 12 years ago by Richard Connon <[email protected]…>

Attached patch fixes the issue by moving black/whitelist handling into the is_package functions on the sources.

I also had to wrap calls to get_deps with "if source.is_package(meta, current):" This could be done better perhaps.

Changed 12 years ago by Richard Connon <[email protected]…>

patch fixing the issue (with correct indentation)

comment:3 Changed 12 years ago by desai

  • Status changed from new to closed
  • Resolution set to fixed

committed in [d57ed55d8effce27305e2d5e8fdd99cfe930ac42] (SVN r6064) thanks for the patch.

WARNING! You need to establish a session before you can create or edit tickets. Otherwise the ticket will get treated as spam.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.