Ticket #979 (closed defect: fixed)
Allow services that are both supervised and custom
Reported by: | https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc | Owned by: | https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc |
---|---|---|---|
Priority: | major | Milestone: | Bcfg2 1.2.0 Release |
Component: | bcfg2-client | Version: | 1.0 |
Keywords: | Cc: |
Description
It is not possible to set a Service to both "supervised" and "custom" mode, so you cannot create a Service that gets started by Bcfg2 _and_ has a custom restart command. Without this possibility, adding a new service with a custom restart requires a full restart of the machines to which the service was added (or other manual intervention).
Another (admittedly rare) use case is a service that you want to be automatically started, but never restarted, even when the bundle is modified. This effect could be obtained by supervising the service and setting target="status" (or similar), but that doesn't work either.
Basically, having to choose between "custom" and "supervised" works fine for services that can be chkconfig'd on during Kickstart (or the equivalent for your OS of choice), but not for services added later. It should be possible to set _both_ a custom restart target _and_ supervised mode. I've attached a patch that obtains this by simply checking for the "target" attribute, since that should by itself be sufficient to designate a custom restart command.
Attachments
Change History
Changed 12 years ago by https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
- Attachment custom-mode.patch added
comment:1 Changed 12 years ago by https://www.google.com/accounts/o8/id?id=AItOawnSjgovXZr-_V3vGkvMSR0pc5LDykRc1Nc
Patch committed: https://github.com/solj/bcfg2/commit/086ff1838634a6b1358234d5c9ba9db295901828
This can be resolved.