Package verification failures are recording wrong error

[jreddy]

This bug exists in Bcfg2 1.1.1.

Packages that are recording "Bad Package" with the reason being version differences are actually not a result of different version. They are actually an issue with specific files from the package having been modified. Take the following for example, "aaa_base" from a SuSE 10 client.

The running "bcfg2 -q -v -d" provides this snippet of output:

Verifying package instances for aaa_base
        0:10-12.58.1.x86_64
        verify_flags = ['', 'nomd5']
 {'files': [['RPMVERIFY_MTIME', 'c', '/etc/inittab'], 
 ['RPMVERIFY_FILESIZE', 'RPMVERIFY_MTIME', 'c', '/etc/mailcap'],
 ['RPMVERIFY_FILESIZE', 'RPMVERIFY_MTIME', 'c', '/etc/mime.types']],
 'nevra': ('aaa_base', None, '10', '12.58.1', 'x86_64')}
        Modlist/Ignore match: /etc/inittab
*** Instance 0:10-12.58.1.x86_64 failed RPM verification ***
        Package aaa_base failed verification.

It's clear that the error here is a result of the 3 files from the aaa_base RPM having been modified. However, the error gets recorded in the database as a version discrepancy, and not as files having been modified.

Reporting deviation from expected state must be done accurately in order to correct configurations.

[solj]

The current reporting model doesn't account for this 'reason'

class Reason(models.Model):
    """reason why modified or bad entry did not verify, or changed."""
    owner = models.TextField(max_length=128, blank=True)
    current_owner = models.TextField(max_length=128, blank=True)
    group = models.TextField(max_length=128, blank=True)
    current_group = models.TextField(max_length=128, blank=True)
    perms = models.TextField(max_length=4, blank=True)  # txt fixes typing issue
    current_perms = models.TextField(max_length=4, blank=True)
    status = models.TextField(max_length=3, blank=True)  # on/off/(None)
    current_status = models.TextField(max_length=1, blank=True)  # on/off/(None)
    to = models.TextField(max_length=256, blank=True)
    current_to = models.TextField(max_length=256, blank=True)
    version = models.TextField(max_length=128, blank=True)
    current_version = models.TextField(max_length=128, blank=True)
    current_exists = models.BooleanField()  # False means its missing. Default True
    current_diff = models.TextField(max_length=1280, blank=True)
    is_binary = models.BooleanField(default=False)

This enhancement will need to be added in 1.2.0

[solj]

Moving to 1.3.0.

[solj]

Created new ticket in github: ​https://github.com/Bcfg2/bcfg2/issues/313